Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE-61 πŸ”¨ 곡용 μ»΄ν¬λ„ŒνŠΈ μˆ˜μ • #24

Merged
merged 8 commits into from
Jul 15, 2024
Merged

FE-61 πŸ”¨ 곡용 μ»΄ν¬λ„ŒνŠΈ μˆ˜μ • #24

merged 8 commits into from
Jul 15, 2024

Conversation

newjinlee
Copy link
Contributor

πŸ”– Issue Ticket

Ticket

✍️ Description

λ©˜ν† λ§μ˜ ν”Όλ“œλ°±μ„ λ°˜μ˜ν•œ fix PRμž…λ‹ˆλ‹€.

βœ… Checklist

PR

  • Branch Convention 확인

epic/ 에픽, feat/ 피쳐, fix/ 버그 μˆ˜μ •, refactor/ κ°œμ„ 

  • Base Branch 확인
  • μ μ ˆν•œ Label 지정
  • Assignee 및 Reviewer 지정

Test

  • 둜컬 μž‘λ™ 확인

Additional Notes

  • (μ—†μŒ)

newjinlee added 7 commits July 15, 2024 10:21
@newjinlee
FE-61 πŸ”¨ eslint κ·œμΉ™ μˆ˜μ •
2c6445a
@newjinlee
FE-61 πŸ”₯ InteractiveEmotionIconCard μ‚­μ œ
2ddc398 
λ‹¨μˆœ λž˜ν•‘ κΈ°λŠ₯밖에 μ—†λŠ” μ»΄ν¬λ„ŒνŠΈ μ‚­μ œ / emotionselectorμ—μ„œ emotioniconcardλ₯Ό 직접 μ‚¬μš©ν•˜λ„λ‘ μˆ˜μ •
@newjinlee
FE-61 πŸ”¨ EpigramCard μ‚¬μ΄μ¦ˆ μž¬μ •μ˜
3a0e0a0 
base -> xs둜 λ³€κ²½
@newjinlee
FE-61 πŸ“ 곡용 μ»΄ν¬λ„ŒνŠΈ ν…ŒμŠ€νŠΈ ν…μŠ€νŠΈ 주석 μΆ”κ°€
6dd4a48
@newjinlee
FE-61 πŸ”¨ CommentCard νƒ€μž… λ‚΄λΆ€ μ •μ˜
78d6bd0
@newjinlee
FE-61 🚚 감정 μΉ΄λ“œ 폴더 ꡬ쑰 λ³€κ²½
2430b6a
@newjinlee
FE-61 πŸ“ 감정 μΉ΄λ“œ, 감정 μ…€λ ‰ν„° 주석 μΆ”κ°€
3732b6f
@newjinlee newjinlee added Priority: Medium πŸ”– μš°μ„ μˆœμœ„ 보톡 Type: Bug πŸ› 버그 labels Jul 15, 2024
@newjinlee newjinlee requested a review from a team July 15, 2024 01:32
@newjinlee newjinlee self-assigned this Jul 15, 2024
@newjinlee newjinlee requested review from JeonYumin94, jangmoonwon, jisurk and imsoohyeok and removed request for a team July 15, 2024 01:46
imsoohyeok
imsoohyeok approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@imsoohyeok imsoohyeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘πŸ» Good

@newjinlee newjinlee merged commit e37fa06 into epic/FE-46-common-components Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imsoohyeok imsoohyeok imsoohyeok approved these changes

@JeonYumin94 JeonYumin94 Awaiting requested review from JeonYumin94

@jangmoonwon jangmoonwon Awaiting requested review from jangmoonwon

@jisurk jisurk Awaiting requested review from jisurk

Assignees

@newjinlee newjinlee

Labels
Priority: Medium πŸ”– μš°μ„ μˆœμœ„ 보톡 Type: Bug πŸ› 버그
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newjinlee @imsoohyeok